Test: add unit tests for ClinicController#175
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a new Spring MVC web-layer test class Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/test/java/org/example/vet1177/controller/ClinicControllerTest.java (1)
28-51: Add one validation-failure test for@Validrequest constraints.Current coverage is only the happy path. Add a bad-request case (e.g., blank
name) to verify controller validation behavior.Suggested additional test
+ `@Test` + void shouldReturnBadRequestWhenNameIsBlank() throws Exception { + String json = """ + { + "name": "", + "address": "Street", + "phoneNumber": "123" + } + """; + + mockMvc.perform(post("/api/clinics") + .contentType("application/json") + .content(json)) + .andExpect(status().isBadRequest()); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/org/example/vet1177/controller/ClinicControllerTest.java` around lines 28 - 51, Add a new test in ClinicControllerTest that posts an invalid Clinic JSON (e.g., "name": "" or missing) to the same "/api/clinics" endpoint to assert validation fails: perform mockMvc.perform(post("/api/clinics")...).contentType("application/json").content(invalidJson)) and expect status().isBadRequest(); also verify clinicService.create(...) was not invoked (use verify(clinicService, never()).create(...)) to ensure the controller's `@Valid` constraints short-circuit processing. Place this alongside shouldCreateClinic() and name it something like shouldReturnBadRequestWhenNameBlank().
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/test/java/org/example/vet1177/controller/ClinicControllerTest.java`:
- Line 33: The test currently stubs clinicService.create with
when(clinicService.create(any(), any(), any())).thenReturn(clinic), which masks
incorrect argument mapping; change the stubbing to use exact expected values
(e.g., when(clinicService.create(eq(expectedName), eq(expectedAddress),
eq(expectedOwner))).thenReturn(clinic)) or remove the stub and use an
ArgumentCaptor to capture the actual arguments passed to clinicService.create in
ClinicControllerTest, then assert those captured values equal the expected
request fields and add verify(clinicService).create(...) to ensure it was
invoked once with the correct arguments.
---
Nitpick comments:
In `@src/test/java/org/example/vet1177/controller/ClinicControllerTest.java`:
- Around line 28-51: Add a new test in ClinicControllerTest that posts an
invalid Clinic JSON (e.g., "name": "" or missing) to the same "/api/clinics"
endpoint to assert validation fails: perform
mockMvc.perform(post("/api/clinics")...).contentType("application/json").content(invalidJson))
and expect status().isBadRequest(); also verify clinicService.create(...) was
not invoked (use verify(clinicService, never()).create(...)) to ensure the
controller's `@Valid` constraints short-circuit processing. Place this alongside
shouldCreateClinic() and name it something like
shouldReturnBadRequestWhenNameBlank().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9fbd61a6-85d1-46ca-9f33-a07b3f647461
📒 Files selected for processing (1)
src/test/java/org/example/vet1177/controller/ClinicControllerTest.java
…e mapping Use explicit argument matching instead of any() and verify that the controller invokes ClinicService with the correct values.
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit